Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make api usecases scaffold #28

Merged
merged 1 commit into from
Oct 14, 2021
Merged

chore: make api usecases scaffold #28

merged 1 commit into from
Oct 14, 2021

Conversation

NYARAS
Copy link
Contributor

@NYARAS NYARAS commented Oct 14, 2021

Signed-off-by: Otieno Calvine nyarangaotieno@gmail.com

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@NYARAS
chore: make api usecases scaffold
8922328 
Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>
maxwellgithinji
maxwellgithinji approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@maxwellgithinji maxwellgithinji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxwellgithinji maxwellgithinji merged commit 48cfaa7 into layout-facility-api Oct 14, 2021
Salaton added a commit that referenced this pull request Nov 4, 2021
@Salaton @maxwellgithinji
@KathurimaKimathi @NYARAS
release: develop to main (#85)
c9f958d 
* chore: add signup usecase implementation (#11)

* implement login usecase (#13)

* chore: layout and implement create facility API

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: implement create facility api logic (#20)

Create a healthcare facility
MFL code must be unique accross platform
Map the output to a format that can be consumed by frontend

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: wire up ci configuration and unit tests (#22)

Depend on postgreSQL docker image for integration tests
Write mocks for unit testing

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add fetch all facilities api (#24)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: implement retrieve one facility by id (#21)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* feat: add delete facility feature (#25)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* chore: replace int id with uuid (#26)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* add metrics capture feature (#27)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* chore: make api usecases scaffold (#28)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: scaffold staff usecases (#31)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* chore: fetch by active status and ensure facility creation idempotency (#32)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* chore: scaffold client and user usecases (#33)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: scaffold user staff models (#34)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* chore: change uuid to type string (#37)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* feat: implement set up user pin to save user's pin and exponential back off (#40)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* chore: implement register staff user (#39)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* feat: implement set up user's login api (#36)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: create client-user profile (#41)

* feat: implement contacts, languages, user input for staff user (#42)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* feat: implement adding client identifiers (#43)

* implement exponential back off (#44)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: implement staff address (#45)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* feat: implement roles (#46)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* add update staff user acddress and contacts (#47)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: add invite client API (#50)

This MR adds a feature where we send an invite to a user (client/staff).
The invite contains a link to the app/play store and a temporary pin.
The invite channel is SMS

* add transfer client feature (#48)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: implement reset pin (#52)

This functionality can be used by admins or healthcare workers to generate and send
a new PIN for a client or other user. The new PIN is generated automatically.

* feat: implement ans ship facility usecase (#54)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* chore: update service name (#55)

* chore: add database envs (#56)

* fix: minor tweaks (#57)

* feat: implement creating a user with a client profile (#59)

* update and standardize facility mock test (#61)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: add set user pin API (#60)

This adds the functionality for setting a user pin. It can be used to
set a PIN for the first time or even change the pin, on first login
after invite or after a pin expires

* feat: paginate facilities (#58)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* fix: update deployment pipeline (#65)

The deployment pipeline is updated to: When we merge to develop, it
deploys to the testing environment and when we deploy to main branch, it
deploys to prod.

* refactor code to enforce loose coupling for easier testing (#64)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: implement login by phone (#63)

* feat: filter facilities (#59) (#66)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* test: add gorm integration tests (#67)

* chore: publish schema to test schema registry (#68)

* fix: add Schema Registry CLI command version (#69)

* fix: add schema registry URL env variable (#71)

* fix: add registry URL env variable (#73)

* fix: add url flag argument to push schema command (#74)

* restore and fix usecase unit tests (#72)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* add client usecase unit tests (#78)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* fix: update onboarding service version (#75)

* chore: publish schema to prod schema registry (#80)

* add client usecase set user pin unit tests (#79)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* feat: search facilities (#76)

Signed-off-by: maxwellgithinji <maxwellgithinji@gmail.com>

* chore: remove unwanted files (#83)

Co-authored-by: Maxwell Githinji <maxwellgithinji@gmail.com>
Co-authored-by: Kathurima Kimathi <41376826+KathurimaKimathi@users.noreply.github.com>
Co-authored-by: Otieno Calvine <nyarangaotieno@gmail.com>
Co-authored-by: Otieno Calvine <35563516+NYARAS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellgithinji maxwellgithinji maxwellgithinji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NYARAS @maxwellgithinji