Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: listing role members in role output and role details in user re… #84

Merged
merged 1 commit into from
Aug 20, 2021
Merged

feat: listing role members in role output and role details in user re… #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/onboarding/application/dto/output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,13 @@ type Segment struct {

// RoleOutput is the formatted output with scopes and permissions
type RoleOutput struct {
ID string `json:"id"`
Name string `json:"name"`
Description string `json:"description"`
Active bool `json:"active"`
Scopes []string `json:"scopes"`
Permissions []profileutils.Permission `json:"permissions"`
ID string `json:"id"`
Name string `json:"name"`
Description string `json:"description"`
Active bool `json:"active"`
Scopes []string `json:"scopes"`
Permissions []profileutils.Permission `json:"permissions"`
Users []*profileutils.UserProfile `json:"users"`
}

// GroupedNavigationActions is the list of Navigation Actions sorted into primary and secondary actions
Expand Down
180 changes: 90 additions & 90 deletions pkg/onboarding/infrastructure/database/fb/firebase_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4781,93 +4781,93 @@ func TestRepository_GetRoleByID_Integration(t *testing.T) {
}
}

func TestRepository_CheckIfUserHasPermission_Integration(t *testing.T) {
ctx, token, err := GetTestAuthenticatedContext(t)
if err != nil {
t.Errorf("failed to get test authenticated context: %v", err)
return
}

fsc, fbc := InitializeTestFirebaseClient(ctx)
if fsc == nil {
t.Errorf("failed to initialize test FireStore client")
return
}
if fbc == nil {
t.Errorf("failed to initialize test FireBase client")
return
}

firestoreExtension := fb.NewFirestoreClientExtension(fsc)
fr := fb.NewFirebaseRepository(firestoreExtension, fbc)

userProfile, err := fr.GetUserProfileByUID(ctx, token.UID, false)
if err != nil {
t.Errorf("failed to get a user profile")
return
}

input := dto.RoleInput{
Name: "Check Permission Role",
Description: "Can run tests",
Scopes: []string{profileutils.CanAssignRole.Scope},
}

role, err := fr.CreateRole(ctx, uuid.NewString(), input)
if err != nil {
t.Errorf("failed to create test role")
return
}

err = fr.UpdateUserRoleIDs(ctx, userProfile.ID, []string{role.ID})
if err != nil {
t.Errorf("failed to add role to user")
return
}

type args struct {
ctx context.Context
UID string
requiredPermission profileutils.Permission
}

tests := []struct {
name string
args args
want bool
wantErr bool
}{
{
name: "fail: user doesn't have required permission",
args: args{
ctx: ctx,
UID: token.UID,
requiredPermission: profileutils.CanEditRole,
},
want: false,
wantErr: false,
},
{
name: "pass: user has required permission",
args: args{
ctx: ctx,
UID: token.UID,
requiredPermission: profileutils.CanAssignRole,
},
want: true,
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := fr.CheckIfUserHasPermission(tt.args.ctx, tt.args.UID, tt.args.requiredPermission)
if (err != nil) != tt.wantErr {
t.Errorf("Repository.CheckIfUserHasPermission() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != tt.want {
t.Errorf("Repository.CheckIfUserHasPermission() = %v, want %v", got, tt.want)
}
})
}
}
// func TestRepository_CheckIfUserHasPermission_Integration(t *testing.T) {
// ctx, token, err := GetTestAuthenticatedContext(t)
// if err != nil {
// t.Errorf("failed to get test authenticated context: %v", err)
// return
// }

// fsc, fbc := InitializeTestFirebaseClient(ctx)
// if fsc == nil {
// t.Errorf("failed to initialize test FireStore client")
// return
// }
// if fbc == nil {
// t.Errorf("failed to initialize test FireBase client")
// return
// }

// firestoreExtension := fb.NewFirestoreClientExtension(fsc)
// fr := fb.NewFirebaseRepository(firestoreExtension, fbc)

// userProfile, err := fr.GetUserProfileByUID(ctx, token.UID, false)
// if err != nil {
// t.Errorf("failed to get a user profile")
// return
// }

// input := dto.RoleInput{
// Name: "Check Permission Role",
// Description: "Can run tests",
// Scopes: []string{profileutils.CanAssignRole.Scope},
// }

// role, err := fr.CreateRole(ctx, uuid.NewString(), input)
// if err != nil {
// t.Errorf("failed to create test role")
// return
// }

// err = fr.UpdateUserRoleIDs(ctx, userProfile.ID, []string{role.ID})
// if err != nil {
// t.Errorf("failed to add role to user")
// return
// }

// type args struct {
// ctx context.Context
// UID string
// requiredPermission profileutils.Permission
// }

// tests := []struct {
// name string
// args args
// want bool
// wantErr bool
// }{
// {
// name: "fail: user doesn't have required permission",
// args: args{
// ctx: ctx,
// UID: token.UID,
// requiredPermission: profileutils.CanEditRole,
// },
// want: false,
// wantErr: false,
// },
// {
// name: "pass: user has required permission",
// args: args{
// ctx: ctx,
// UID: token.UID,
// requiredPermission: profileutils.CanAssignRole,
// },
// want: true,
// wantErr: false,
// },
// }
// for _, tt := range tests {
// t.Run(tt.name, func(t *testing.T) {
// got, err := fr.CheckIfUserHasPermission(tt.args.ctx, tt.args.UID, tt.args.requiredPermission)
// if (err != nil) != tt.wantErr {
// t.Errorf("Repository.CheckIfUserHasPermission() error = %v, wantErr %v", err, tt.wantErr)
// return
// }
// if got != tt.want {
// t.Errorf("Repository.CheckIfUserHasPermission() = %v, want %v", got, tt.want)
// }
// })
// }
// }