Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: use shortcut to end recording #21

Open
danshapiro opened this issue Jan 1, 2024 · 6 comments
Open

Feature request: use shortcut to end recording #21

danshapiro opened this issue Jan 1, 2024 · 6 comments

Comments

@danshapiro
Copy link

I propose a use_shortcut_to_end config setting. If True, it would ignore silence_duration, and end the recording when the user presses the shortcut key a second time.

@savbell
Copy link
Owner

savbell commented Jan 2, 2024

Thanks for the feature request! I just made a Roadmap section in the Readme and added it as something I plan on investigating :)

@danshapiro
Copy link
Author

I hacked together a version of it - in case it's helpful.

https://github.com/danshapiro/whisper-writer

@thfrei
Copy link

thfrei commented Jan 3, 2024

Dear both.
Thank you for providing the software. I second the request and also looked at the code. Looks good to me. I also like the logging additions in knowing, which sound device was selected, what the reason for ending is/was.

When having the shortcut, one can extend the timeout time and thus, continue talking and making breaks when thinking. It is a nice workaround for "live/continous" transcribing.

@savbell What do you mean in your Roadmap with "Pipelining audio files"? Is this like "continous" transcribing...? I think it would be nice to have like a batch mode..., whenever there is like 500ms or something of silence it can start transcribing and record to a new temp file? Or what should we call this feature?

@thfrei
Copy link

thfrei commented Jan 22, 2024

I have created a new branch in my fork that let's you end recording when pressing shortcut, but also: does continous recording, transcribing and typing. This improved at least for me the usability, since I need to think while "dictating".

https://github.com/thfrei/whisper-writer

Thanks both of you for your inspiration and code! It made me finally dive into python and multi-processing :-)

@savbell
Copy link
Owner

savbell commented Jan 26, 2024

Hi, thank you both for your comments and code! It's super cool to see people using the tool and being inspired to modify it :) Sorry for being a bit absent -- I'm busy with school so haven't been checking here!

I just approved a PR for push-to-talk, although this implementation is more hold-down-to-talk: #28

I definitely want to take the time to look through the code you shared and add these additional features. I'll try to get to it within the next week. If you want to merge your changes into main, feel free to create a PR! :)

@danshapiro
Copy link
Author

danshapiro commented Jan 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants