Fixed KdocComments and KdocFormatting
#1892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es in class KDoc at the same time
…aven't empty line before them - added smoke test for class kdoc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1892 +/- ##
============================================
+ Coverage 76.79% 76.82% +0.03%
+ Complexity 2492 2476 -16
============================================
Files 134 134
Lines 7898 7883 -15
Branches 2240 2230 -10
============================================
- Hits 6065 6056 -9
+ Misses 828 826 -2
+ Partials 1005 1001 -4 ☔ View full report in Codecov by Sentry. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 167 files ±0 167 suites ±0 7m 19s ⏱️ -39s Results for commit 24166ca. ± Comparison against base commit f63b045. ♻️ This comment has been updated with latest results. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 167 files ±0 167 suites ±0 2m 49s ⏱️ -54s Results for commit 24166ca. ± Comparison against base commit f63b045. ♻️ This comment has been updated with latest results. |
orchestr7
reviewed
Dec 24, 2023
...t-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt
Show resolved
Hide resolved
orchestr7
reviewed
Dec 24, 2023
...t-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt
Show resolved
Hide resolved
orchestr7
reviewed
Dec 24, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt
Show resolved
Hide resolved
orchestr7
reviewed
Dec 24, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt
Outdated
Show resolved
Hide resolved
orchestr7
approved these changes
Dec 24, 2023
orchestr7
reviewed
Dec 24, 2023
diktat-cli/src/test/resources/test/smoke/src/main/kotlin/ClassKdocExpected.kt
Show resolved
Hide resolved
orchestr7
reviewed
Dec 24, 2023
diktat-rules/src/test/resources/test/paragraph2/kdoc/ConstructorCommentPropertiesTest.kt
Show resolved
Hide resolved
orchestr7
reviewed
Dec 24, 2023
diktat-rules/src/test/resources/test/paragraph2/kdoc/ConstructorCommentKDocExpected.kt
Show resolved
Hide resolved
nulls
reviewed
Dec 25, 2023
diktat-rules/src/test/resources/test/paragraph2/kdoc/ConstructorCommentNoKDocTest.kt
Show resolved
Hide resolved
…ugfix/kdoc_formatting # Conflicts: # diktat-cli/src/test/kotlin/com/saveourtool/diktat/smoke/DiktatSmokeTestBase.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
KdocComments.KdocFormattingfor case when@propertyand@constructorbasic tags haven't empty line before them.@propertytag.Closes #1884