ci: Do not run code coverage on forks #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospereira
force-pushed
the
ci/disable-jobs-when-forks
branch
from
7d986ee
to
0cc9d13
Compare
orchestr7
reviewed
Jan 9, 2024
orchestr7
reviewed
Jan 9, 2024
marcospereira
commented
Jan 9, 2024
There was a problem hiding this comment.
Thanks for reviewing, @akuleshov7. I replied with a few questions.
lgtm, I am trying to understand why CI has freezes (today GitHub had outage) |
orchestr7
approved these changes
Jan 9, 2024
|
Reopened PR to restart CI actions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1900 +/- ##
============================================
- Coverage 78.27% 78.26% -0.02%
Complexity 2478 2478
============================================
Files 134 134
Lines 8724 8724
Branches 2216 2216
============================================
- Hits 6829 6828 -1
- Misses 906 907 +1
Partials 989 989 ☔ View full report in Codecov by Sentry. |
|
Thank you, @akuleshov7. It seems this is good to go now. :-) |
|
@marcospereira merged, thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disable code coverage uploading when running on forks. This is useful so that
contributors can enable GitHub Actions on their forks without having false
negatives due to lack of codecov configuration.
Which rule and warnings did you add?
None.
Actions checklist
Implemented Rule, added WarningsAdded tests on checksAdded tests on fixersUpdated diktat-analysis.ymlUpdated available-rules.md