Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for actual warning in SAVE from the file #366

Merged
merged 11 commits into from
Jan 23, 2023
Merged

Conversation

Cheshiriks
Copy link
Member

What's done:

  • test for actual warning in SAVE from the file

What's done:
* Added reading of actual warning from the file
@Cheshiriks Cheshiriks marked this pull request as draft February 14, 2022 16:10
@kgevorkyan
Copy link
Member

@Cheshiriks Please remind what's the problem was with this PR and could it be continued?

@Cheshiriks Cheshiriks marked this pull request as ready for review January 18, 2023 15:11
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests  +2   221 ✔️ +2   10m 14s ⏱️ -2s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit f256883. ± Comparison against base commit 9074bba.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 18, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests  +2   221 ✔️ +2   11m 23s ⏱️ - 6m 52s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit f256883. ± Comparison against base commit 9074bba.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 18, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

245 tests  +2   221 ✔️ +2   14m 13s ⏱️ + 3m 34s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit f256883. ± Comparison against base commit 9074bba.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #366 (f256883) into main (9074bba) will decrease coverage by 0.05%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##               main     #366      +/-   ##
============================================
- Coverage     47.50%   47.46%   -0.05%     
- Complexity      158      159       +1     
============================================
  Files            53       53              
  Lines          1846     1852       +6     
  Branches        316      316              
============================================
+ Hits            877      879       +2     
- Misses          837      840       +3     
- Partials        132      133       +1     
Flag Coverage Δ
unittests 47.46% <28.57%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lin/com/saveourtool/save/plugin/warn/WarnPlugin.kt 59.88% <28.57%> (-0.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Cheshiriks Cheshiriks merged commit 1fe5103 into main Jan 23, 2023
@Cheshiriks Cheshiriks deleted the feature/test-for-actual branch January 23, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants