Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility for save-overrides.toml #442

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

nulls
Copy link
Member

@nulls nulls commented Aug 29, 2022

What's done:

A default value for overridesPluginConfigs in ConfigDetector, this field breaks preprocessor

### What's done:
A default value for `overridesPluginConfigs` in ConfigDetector, this field breaks preprocessor
@nulls nulls self-assigned this Aug 29, 2022
@nulls nulls marked this pull request as ready for review August 29, 2022 11:52
@nulls nulls enabled auto-merge (squash) August 29, 2022 11:58
@nulls nulls changed the title Backward compatibility Backward compatibility for save-overrides.toml Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #442 (5224a6c) into main (a7809a8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #442      +/-   ##
============================================
- Coverage     46.64%   46.61%   -0.03%     
+ Complexity      151      150       -1     
============================================
  Files            53       53              
  Lines          1771     1772       +1     
  Branches        331      331              
============================================
  Hits            826      826              
- Misses          813      814       +1     
  Partials        132      132              
Flag Coverage Δ
unittests 46.61% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../com/saveourtool/save/core/files/ConfigDetector.kt 93.54% <100.00%> (-1.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls nulls merged commit c3fce0e into main Aug 29, 2022
@nulls nulls deleted the hotfix/save-overrides.toml#435 branch August 29, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants