Support escaping commas in extra flags #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
save-common/src/commonMain/kotlin/com/saveourtool/save/core/plugin/ExtraFlagsExtractor.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonMain/kotlin/com/saveourtool/save/core/plugin/ExtraFlagsExtractor.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonMain/kotlin/com/saveourtool/save/core/plugin/ExtraFlagsExtractor.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonMain/kotlin/com/saveourtool/save/core/plugin/ExtraFlagsExtractor.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonMain/kotlin/com/saveourtool/save/core/plugin/ExtraFlagsExtractor.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonMain/kotlin/com/saveourtool/save/core/plugin/ExtraFlagsExtractor.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonNonJsTest/kotlin/com/saveourtool/save/core/ExtraFlagsExtractorTest.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonNonJsTest/kotlin/com/saveourtool/save/core/ExtraFlagsExtractorTest.kt
Fixed
Show fixed
Hide fixed
save-common/src/commonNonJsTest/kotlin/com/saveourtool/save/core/ExtraFlagsExtractorTest.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
============================================
+ Coverage 46.61% 47.00% +0.38%
Complexity 150 150
============================================
Files 53 53
Lines 1772 1785 +13
Branches 331 332 +1
============================================
+ Hits 826 839 +13
Misses 814 814
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orchestr7
reviewed
Aug 30, 2022
| @@ -29,7 +29,8 @@ class ExtraFlagsExtractor(private val generalConfig: GeneralConfig, | |||
| * @return [ExtraFlags] or null if no match occurred | |||
| */ | |||
| internal fun extractExtraFlagsFrom(line: String) = line | |||
| .split(",", ", ") | |||
| .splitByNonEscaped(',') | |||
| .map { it.replace("\\,", ",") } | |||
There was a problem hiding this comment.
case with escaping of a single slash won't work here:
aaa\\,bbb\\, -> usually it is converted to aaa\,bbb\,
orchestr7
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.