Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt FixPlugin for library for applying of SARIF fix patches #464

Merged
merged 7 commits into from
Dec 2, 2022

Conversation

kgevorkyan
Copy link
Member

What's done:

  • Adapt FixPlugin for library for applying of SARIF fix patches

FixAndWarnPlugin use FixPlugin for fixing test files and comparing with expected, which are released of warnings at the moment of FixPlugin start, so there is no need to make changes in FixAndWarnPlugin

### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
@kgevorkyan kgevorkyan linked an issue Nov 29, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 29, 2022

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

239 tests  ±0   215 ✔️ ±0   8m 50s ⏱️ -5s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 118317c. ± Comparison against base commit 09feb36.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

239 tests  ±0   215 ✔️ ±0   10m 42s ⏱️ -1s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 118317c. ± Comparison against base commit 09feb36.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

239 tests  ±0   215 ✔️ ±0   17m 32s ⏱️ + 2m 26s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 118317c. ± Comparison against base commit 09feb36.

♻️ This comment has been updated with latest results.

### What's done:
* codestyle
### What's done:
* codestyle
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #464 (4f4308c) into main (e557722) will decrease coverage by 0.07%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##               main     #464      +/-   ##
============================================
- Coverage     47.77%   47.70%   -0.08%     
- Complexity      147      149       +2     
============================================
  Files            52       53       +1     
  Lines          1779     1790      +11     
  Branches        308      313       +5     
============================================
+ Hits            850      854       +4     
- Misses          803      807       +4     
- Partials        126      129       +3     
Flag Coverage Δ
unittests 47.70% <69.23%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lin/com/saveourtool/save/core/config/FixFormats.kt 0.00% <0.00%> (ø)
...om/saveourtool/save/plugins/fix/FixPluginConfig.kt 43.58% <44.44%> (-1.87%) ⬇️
...tlin/com/saveourtool/save/plugins/fix/FixPlugin.kt 60.68% <50.00%> (-0.43%) ⬇️
...urtool/save/plugins/fixandwarn/FixAndWarnPlugin.kt 92.04% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kgevorkyan kgevorkyan marked this pull request as ready for review November 30, 2022 08:40
@kgevorkyan kgevorkyan enabled auto-merge (squash) December 2, 2022 07:22
@kgevorkyan kgevorkyan merged commit cf1d71d into main Dec 2, 2022
@kgevorkyan kgevorkyan deleted the feture/sarif_fix_adapter branch December 2, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt FixPlugin for library for applying of SARIF fix patches
2 participants