Execute tool in sarif mode before report checking #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
save-plugins/warn-plugin/src/commonMain/kotlin/com/saveourtool/save/plugin/warn/WarnPlugin.kt
Fixed
Show fixed
Hide fixed
save-plugins/warn-plugin/src/commonMain/kotlin/com/saveourtool/save/plugin/warn/WarnPlugin.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
============================================
+ Coverage 47.52% 47.70% +0.18%
Complexity 159 159
============================================
Files 53 53
Lines 1856 1855 -1
Branches 316 316
============================================
+ Hits 882 885 +3
+ Misses 841 838 -3
+ Partials 133 132 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kgevorkyan
commented
Feb 15, 2023
kgevorkyan
commented
Feb 15, 2023
save-plugins/fix-plugin/src/commonMain/kotlin/com/saveourtool/save/plugins/fix/FixPlugin.kt
Show resolved
Hide resolved
save-plugins/warn-plugin/src/commonMain/kotlin/com/saveourtool/save/plugin/warn/WarnPlugin.kt
Fixed
Show fixed
Hide fixed
kgevorkyan
requested review from
orchestr7,
0x6675636b796f75676974687562 and
nulls
Cheshiriks
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Execute tool before checking the sarif report, this logic allows:
.sariffrom stdoutactual[Warnings|Fix]SarifFileNamewas provided and something were changed in reportMinor refactoring
Add possible config for one of the test (however it's not required, since
save-cliwill look into stdout by default)Part of #497