Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publish... tasks depend on sign... tasks #503

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

petertrr
Copy link
Member

Successful run: https://github.com/saveourtool/save-cli/actions/runs/4241944409

All publish... tasks share Javadoc artifact (until we set up proper Javadoc generation), so this PR makes all of them dependent.

Closes #502

Copy link
Member

@kgevorkyan kgevorkyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #503 (e856f59) into main (f284ba6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #503   +/-   ##
=========================================
  Coverage     47.27%   47.27%           
  Complexity      159      159           
=========================================
  Files            53       53           
  Lines          1872     1872           
  Branches        318      318           
=========================================
  Hits            885      885           
  Misses          855      855           
  Partials        132      132           
Flag Coverage Δ
unittests 47.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ ±0   10m 52s ⏱️ +17s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit e856f59. ± Comparison against base commit f284ba6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ ±0   20m 26s ⏱️ + 7m 9s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit e856f59. ± Comparison against base commit f284ba6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   219 ✔️  - 1   16m 41s ⏱️ + 4m 24s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       2 +1 

For more details on these failures, see this check.

Results for commit e856f59. ± Comparison against base commit f284ba6.

♻️ This comment has been updated with latest results.

@petertrr petertrr enabled auto-merge (squash) February 22, 2023 12:49
@petertrr petertrr merged commit d76e538 into main Feb 22, 2023
@petertrr petertrr deleted the bugfix/gradle-publishing branch February 22, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in release action
2 participants