Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct path manipulation on Windows and UNIX (sarif-utils) #504

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

0x6675636b796f75676974687562
Copy link
Member

This fixes #489

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #504 (cae3182) into main (d76e538) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #504      +/-   ##
============================================
- Coverage     47.27%   47.25%   -0.03%     
  Complexity      159      159              
============================================
  Files            53       53              
  Lines          1872     1873       +1     
  Branches        318      318              
============================================
  Hits            885      885              
- Misses          855      856       +1     
  Partials        132      132              
Flag Coverage Δ
unittests 47.25% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/saveourtool/save/cli/config/SavePropertiesExt.kt 0.00% <0.00%> (ø)
...tlin/com/saveourtool/save/plugins/fix/FixPlugin.kt 54.62% <0.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

97 tests   - 148   93 ✔️  - 128   5s ⏱️ - 10m 24s
21 suites  -   27     4 💤  -   20 
21 files    -   27     0 ±    0 

Results for commit 02de9a7. ± Comparison against base commit d76e538.

This pull request removes 148 tests.
com.saveourtool.save.cli.GeneralTest ‑ examples test from subfolder()[jvm]
com.saveourtool.save.cli.GeneralTest ‑ examples test()[jvm]
com.saveourtool.save.core.ConfigDetectorRegressionTest ‑ config detector regression test on directories()[jvm]
com.saveourtool.save.core.ConfigDetectorRegressionTest ‑ config detector regression test on directories[linuxX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect config file from single Test file()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect config file from single Test file[linuxX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from the middle()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from the middle[linuxX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from top()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from top[linuxX64]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

97 tests   - 148   93 ✔️  - 128   8s ⏱️ - 13m 38s
21 suites  -   27     4 💤  -   20 
21 files    -   27     0 ±    0 

Results for commit 02de9a7. ± Comparison against base commit d76e538.

This pull request removes 148 tests.
com.saveourtool.save.cli.GeneralTest ‑ examples test from subfolder()[jvm]
com.saveourtool.save.cli.GeneralTest ‑ examples test()[jvm]
com.saveourtool.save.core.ConfigDetectorRegressionTest ‑ config detector regression test on directories()[jvm]
com.saveourtool.save.core.ConfigDetectorRegressionTest ‑ config detector regression test on directories[macosX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect config file from single Test file()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect config file from single Test file[macosX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from the middle()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from the middle[macosX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from top()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from top[macosX64]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

97 tests   - 148   93 ✔️  - 128   10s ⏱️ - 14m 13s
21 suites  -   27     4 💤  -   20 
21 files    -   27     0 ±    0 

Results for commit 02de9a7. ± Comparison against base commit d76e538.

This pull request removes 148 tests.
com.saveourtool.save.cli.GeneralTest ‑ examples test from subfolder()[jvm]
com.saveourtool.save.cli.GeneralTest ‑ examples test()[jvm]
com.saveourtool.save.core.ConfigDetectorRegressionTest ‑ config detector regression test on directories()[jvm]
com.saveourtool.save.core.ConfigDetectorRegressionTest ‑ config detector regression test on directories[mingwX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect config file from single Test file()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect config file from single Test file[mingwX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from the middle()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from the middle[mingwX64]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from top()[jvm]
com.saveourtool.save.core.ConfigDetectorTest ‑ should detect multiple files starting from top[mingwX64]
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAVE failing to locate the file specified by artifactLocation in the SARIF content
3 participants