Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JGit usage in gradle #527

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fixed JGit usage in gradle #527

merged 1 commit into from
Apr 24, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Apr 24, 2023

What's done:

  • added search of .git when status is checked

### What's done:
- added search of .git when status is checked
@nulls
Copy link
Member Author

nulls commented Apr 24, 2023

@kgevorkyan I guess sarif-utils needs similar fix. I think it relates to run gradle inside buildSrc where rootProject is buildSrc and it's not a root of git repository. It's not clear why it's not failed in scope of PR, but it fails here https://github.com/saveourtool/save-cli/actions/runs/4784311435.

But, save-cloud fails in PR with upgrading reckon...

@nulls nulls enabled auto-merge (squash) April 24, 2023 09:10
@kgevorkyan
Copy link
Member

@kgevorkyan I guess sarif-utils needs similar fix. I think it relates to run gradle inside buildSrc where rootProject is buildSrc and it's not a root of git repository. It's not clear why it's not failed in scope of PR, but it fails here https://github.com/saveourtool/save-cli/actions/runs/4784311435.

But, save-cloud fails in PR with upgrading reckon...

will take it

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #527 (2a3980c) into main (ce972e2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #527   +/-   ##
=========================================
  Coverage     48.45%   48.45%           
  Complexity      164      164           
=========================================
  Files            53       53           
  Lines          1882     1882           
  Branches        313      313           
=========================================
  Hits            912      912           
  Misses          841      841           
  Partials        129      129           
Flag Coverage Δ
unittests 48.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls nulls merged commit 77ae870 into main Apr 24, 2023
@nulls nulls deleted the bugfix/reckon-upgrade branch April 24, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants