Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the documentation #550

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Updating the documentation #550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
448d194
Updating the documentation
orchestr7 Sep 15, 2023
94ff471
Updating the documentation
orchestr7 Sep 18, 2023
42a630d
Updating the documentation
orchestr7 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/kotlin-library.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ kotlin {
}
}
}
val nativeTargets = listOf(linuxX64(), mingwX64(), macosX64(), /* macosArm64() */)
val nativeTargets = listOf(
linuxX64(),
mingwX64(),
macosX64(),
/* macosArm64() */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is commented ?

)
if (project.name == "save-common") {
// additionally, save-common should be available for JS too
// fixme: shouldn't rely on hardcoded project name here
Expand Down
5 changes: 4 additions & 1 deletion save-cli/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ fun registerNativeBinaries(os: DefaultOperatingSystem, kotlin: KotlinMultiplatfo
val saveTarget = when {
os.isWindows -> listOf(kotlin.mingwX64())
os.isLinux -> listOf(kotlin.linuxX64())
os.isMacOsX -> listOf(kotlin.macosX64(), /* kotlin.macosArm64() */)
os.isMacOsX -> listOf(
kotlin.macosX64(),
/* kotlin.macosArm64() */
)
else -> throw GradleException("Unknown operating system $os")
}

Expand Down