Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd file names in actual result #568

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Odd file names in actual result #568

merged 1 commit into from
Feb 27, 2024

Conversation

nulls
Copy link
Member

@nulls nulls commented Feb 27, 2024

What's done:

  • added checking actual result

It closes #566

### What's done:
- added checking actual result
@nulls nulls self-assigned this Feb 27, 2024
@nulls nulls enabled auto-merge (squash) February 27, 2024 12:57
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.35%. Comparing base (751f8c5) to head (bc6e6e1).

Files Patch % Lines
...veourtool/save/plugin/warn/utils/ResultsChecker.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #568      +/-   ##
============================================
+ Coverage     48.32%   48.35%   +0.03%     
  Complexity      164      164              
============================================
  Files            53       53              
  Lines          1877     1882       +5     
  Branches        313      314       +1     
============================================
+ Hits            907      910       +3     
- Misses          841      842       +1     
- Partials        129      130       +1     
Flag Coverage Δ
unittests 48.35% <60.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@nulls nulls merged commit 29a7c36 into main Feb 27, 2024
14 checks passed
@nulls nulls deleted the bugfix/invalid-actual-result branch February 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silently skips detected actual warning that related test which are not tested
2 participants