Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported ExpectedWarningsFormat.PLAIN #569

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

nulls
Copy link
Member

@nulls nulls commented Feb 27, 2024

What's done:

  • supported reading expected results from external plain file

It closes #567

### What's done:
- supported reading expected results from external plain file
@nulls nulls self-assigned this Feb 27, 2024
Copy link

github-actions bot commented Feb 27, 2024

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✅ ±0   8m 59s ⏱️ +13s
 48 suites ±0    24 💤 ±0 
 48 files   ±0     0 ❌ ±0 

Results for commit f64f5e7. ± Comparison against base commit 29a7c36.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✅ ±0   14m 10s ⏱️ + 5m 20s
 48 suites ±0    24 💤 ±0 
 48 files   ±0     0 ❌ ±0 

Results for commit f64f5e7. ± Comparison against base commit 29a7c36.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✅ ±0   9m 57s ⏱️ + 1m 0s
 48 suites ±0    24 💤 ±0 
 48 files   ±0     0 ❌ ±0 

Results for commit f64f5e7. ± Comparison against base commit 29a7c36.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 48.07%. Comparing base (29a7c36) to head (f64f5e7).

Files Patch % Lines
...lin/com/saveourtool/save/plugin/warn/WarnPlugin.kt 35.00% 12 Missing and 1 partial ⚠️
...rtool/save/plugin/warn/utils/WarningsExtraction.kt 0.00% 5 Missing ⚠️
.../com/saveourtool/save/core/utils/SarifFileUtils.kt 0.00% 3 Missing ⚠️
...com/saveourtool/save/core/config/WarningFormats.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #569      +/-   ##
============================================
- Coverage     48.35%   48.07%   -0.29%     
+ Complexity      164      163       -1     
============================================
  Files            53       53              
  Lines          1882     1893      +11     
  Branches        314      316       +2     
============================================
  Hits            910      910              
- Misses          842      853      +11     
  Partials        130      130              
Flag Coverage Δ
unittests 48.07% <24.13%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nulls nulls requested a review from orchestr7 February 27, 2024 15:13
@nulls nulls marked this pull request as ready for review February 27, 2024 15:13
@nulls nulls merged commit e7d0d24 into main Feb 28, 2024
16 of 17 checks passed
@nulls nulls deleted the feature/external-file-expected-result branch February 28, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process warnings in plain format from the file
2 participants