Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect missing/matched calculation #1039

Closed
orchestr7 opened this issue Aug 14, 2022 · 2 comments · Fixed by saveourtool/save-cli#437 or #1093
Closed

Incorrect missing/matched calculation #1039

orchestr7 opened this issue Aug 14, 2022 · 2 comments · Fixed by saveourtool/save-cli#437 or #1093
Assignees
@nulls
Labels
bug Something isn't working

Comments

@orchestr7
Copy link
Member

orchestr7 commented Aug 14, 2022 •
edited
Loading

image

Please after fixing - also add diktat smoke tests and test examples from master/main of SAVE-cli.

This significantly affects precision and recall.
@orchestr7 orchestr7 added the bug Something isn't working label Aug 14, 2022
@nulls
Copy link
Member

nulls commented Aug 22, 2022

Valid cases. 0 is for fix plugin.
Agreed to change it to N/A for them. Need to investigate where it should be done (save-cli vs save-cloud)

@petertrr petertrr mentioned this issue Aug 23, 2022
Merged
@nulls nulls reopened this Aug 23, 2022
@nulls
Copy link
Member

nulls commented Aug 23, 2022

Need to support changes from saveourtool/save-cli#437

nulls added a commit that referenced this issue Aug 23, 2022
@nulls
Supported notApplicable for FixPlugin
bc86368 
### What's done:
* supported not applicable counter for FixPlugin and empty result

It closes #1039
@nulls nulls mentioned this issue Aug 23, 2022
Merged
nulls added a commit that referenced this issue Aug 23, 2022
@nulls
Supported notApplicable for FixPlugin
5b6f52a 
### What's done:
* supported not applicable counter for FixPlugin and empty result

It closes #1039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@nulls @orchestr7