Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier and strict mode #64

Closed
blackswan-03 opened this issue Jul 22, 2022 · 2 comments
Closed

Prettier and strict mode #64

blackswan-03 opened this issue Jul 22, 2022 · 2 comments

Comments

@blackswan-03
Copy link
Contributor

blackswan-03 commented Jul 22, 2022 •
edited
Loading

I am a bit of a newb, so this may be a dumb question, but should the JS files be re-formatted using VSCode's "Prettier" extension for easier readability, and should they also have "strict" mode implemented to help catch and prevent more errors?

Just wondering🙂
@Savjee
Copy link
Owner

Savjee commented Jul 23, 2022

Strict mode is indeed a good idea!
As for Prettier: I will first add it to the build steps, so that it's automatically checked. Then we can correct any errors manually. I don't like some of the formatting changes you've made in the PR's.

@Savjee
Copy link
Owner

Savjee commented Jul 23, 2022

Never mind, merged them in!
Thanks ;)

@Savjee Savjee closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Savjee @blackswan-03