Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Portuguese from Portugal #203

Closed
wants to merge 1 commit into from
Closed

Created Portuguese from Portugal #203

wants to merge 1 commit into from

Conversation

afonsojramos
Copy link

Created Portuguese from Portugal

Changes proposed in this pull request:

  • Added PT_PT support

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Similar to other languages.

Additional notes

Thought there should be a Original Portuguese version

@coveralls
Copy link

Pull Request Test Coverage Report for Build 475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.22%

Totals Coverage Status
Change from base Build 468: 0.0%
Covered Lines: 2425
Relevant Lines: 2718

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 3, 2018

Pull Request Test Coverage Report for Build 475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.22%

Totals Coverage Status
Change from base Build 468: 0.0%
Covered Lines: 2425
Relevant Lines: 2718

💛 - Coveralls

@afonsojramos
Copy link
Author

Will add Test Coverage in the future

@erozqba
Copy link
Collaborator

erozqba commented Oct 3, 2018

@afonsojramos there is already an effort to do the same on #198 with coverage included. Could you contribute with the other PR?

@afonsojramos
Copy link
Author

There are some heavy differences though, however he already has testing, which would be easily copied to this PR

@erozqba
Copy link
Collaborator

erozqba commented Oct 9, 2018

@afonsojramos even if there are some differences, you should be able to suggest some improvements and collaborate with it? Do you think this implementation is better than the one on the PR #198 in all aspects? If not, then suggest the improvements you can see on PR #198. I would like to promote collaboration between different developers working on the same feature than choose the work of one of the developers over the other.

@erozqba
Copy link
Collaborator

erozqba commented Oct 20, 2018

@afonsojramos PR #198 get merged, if you have suggestions to do, create a new PR.

@erozqba erozqba closed this Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants