Issue 229: Add explicit encoding, license and unix line separators.

[erozqba]

Fixes #229

Changes proposed in this pull request:

Some maintainers for different Linux distribution are having some
problems with the encoding in different python versions. This change
intents to make all python files define explicitly the encoding, license,
and Unix line separators. Remove one example of the README.rst file
where a possible non UTF-8 character is used.

Status

• READY
• HOLD
• WIP (Work-In-Progress)

How to verify this change

Make sure all tests pass and coverage remains the same.

[null-git]

Thanks for this, but it doesn't build either:

===>  Configuring for py36-num2words-0.5.8_1
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 59, in <module>
    version=find_version("bin/num2words"),
  File "setup.py", line 47, in find_version
    for line in fp:
  File "/usr/local/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 747: ordinal not in range(128)
*** Error code 1

This is the same example in bin/num2words:27 that was removed from README.rst. Removing this line as well does the trick. But wouldn't it be nicer to just open those specific files as utf-8? As they are opened by open(), the "coding: utf-8" line doesn't do anything for this. Replacing open() with io.open() might do it? This seems to be available for python2.7 as well and to be the same as open() in python3+

[erozqba]

@null-git I agree! I will also use the io.open(..., encoding="utf-8")

I have updated my branch, could you give it a try again?

[null-git]

This builds fine now for with python 3.6 but you've used encoding='utf-8' for open() instead of io.open(). This should fail for python 2.7.

[null-git]

Sorry, I completely missed that. I think it's fine how you did it, other people won't care to much which open() this is and as python 2.7 is hopefully gone soonish anyway, both functions will be the same for most people anyway. Looks good to me.

[pierreduchemin]

Hi @erozqba,
Here are just a few basic questions before merge.
LGTM otherwise.

[coveralls]

Pull Request Test Coverage Report for Build 601

• 556 of 601 (92.51%) changed or added relevant lines in 10 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.579%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
num2words/lang_UK.py	58	59	98.31%
num2words/lang_TH.py	102	105	97.14%
num2words/lang_HE.py	17	58	29.31%

Totals
Change from base Build 595:	0.0%
Covered Lines:	4741
Relevant Lines:	5027

---

💛 - Coveralls

[erozqba]

@pierreduchemin Please review this PR again, it should be ready. Please review carefully the files on which I have changed the line end. Thanks a lot.

[pierreduchemin]

Carefully reviewed.
LGTM