Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian issues 259 #260

Merged
merged 9 commits into from
Dec 31, 2019
Merged

Conversation

mariaS210
Copy link
Contributor

Fixes #259 reported by @silvium

Changes proposed in this pull request:

  • 2 has different gender form when in hundreds or thousands area
  • currency for 100 and 1000 has una instead of o, like on banknotes
  • 10.000 - 100.000 with increment by 10.000 badly represented

Status

  • [X ] READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Issues reported:
Different treatment for 2:
num2words(22000, lang='ro')
until now: douăzeci și doi mie
from now: douăzeci și două mii

Currency for 100 and 1000 has a different form than years or simply numerals:
num2words(1000, lang='ro', to='currency')
until now: o mie
from now: una mie

10.000 - 100.000 with increment by 10.000 were badly represented:
num2words(20000, lang='ro')
until now: douăzeci și mie/i
from now: douăzeci mii

Additional notes

@coveralls
Copy link

coveralls commented Jun 9, 2019

Pull Request Test Coverage Report for Build 838

  • 40 of 40 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.156%

Totals Coverage Status
Change from base Build 837: 0.02%
Covered Lines: 10130
Relevant Lines: 10496

💛 - Coveralls

@mariaS210
Copy link
Contributor Author

pet-423398_640
this puppy is sad that pull request is not reviewed

Image by Winsker from Pixabay

erozqba
erozqba previously approved these changes Oct 25, 2019
@mariaS210
Copy link
Contributor Author

hi @erozqba !
i noticed that i did not implement pluralize as defined in http://docs.translatehouse.org/projects/localization-guide/en/latest/l10n/pluralforms.html and that indeed Romanian has another plural form which i ignored. i have implemented it now.
could you please take another look?
thank you, and sorry for the delay

@erozqba
Copy link
Collaborator

erozqba commented Dec 31, 2019

Thanks a lot for your contribution @mariaS210 and please accept my apologies for all the time it takes to review and merge this 😭

@erozqba erozqba merged commit ca33d8b into savoirfairelinux:master Dec 31, 2019
@mariaS210
Copy link
Contributor Author

Thanks a lot for your contribution @mariaS210 and please accept my apologies for all the time it takes to review and merge this 😭

no worries @erozqba i had an excuse to search pictures of puppies on the internet 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Romanian language issues:
3 participants