Add simple tests for lang_DK.py #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 827
💛 - Coveralls |
erozqba
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # by...
Work toward #109
Changes proposed in this pull request:
Status
How to verify this change
Increase present in coverage report
Additional notes
The code DK seems to refer to the country of Denmark, not the language of Danish which has the locale abbreviation da (da_DK is also valid). Should this be updated as well?
Further values seem incorrect from what I can quickly find online, I could use review or help from someone who knows more about the language.
num2words(1000, lang='dk', to='ordinal') == 'ettusindte'
num2words(12345, lang='dk', to='ordinal') == 'tolvtusinde og trehundrede og femogfyrre'
but what I can find shows the values should be 'et tusind' and 'tolv tusinde tre hundrede og femogfyrre' respectively. As I'm not sure which is correct (if not both), I don't want to add any failing test cases I can't validate.