Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr] return Turkish 0 ordinal and cardinal #347

Merged
merged 4 commits into from May 7, 2021

Conversation

cyriaka90
Copy link
Contributor

Fixes # by cyriaka90

Changes proposed in this pull request:

  • 0 (cardinal) -> sıfır
  • 0 (ordinal) -> sıfırıncı

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Fill out this section so that a reviewer can know how to verify your change.

Additional notes

fixes #346

If applicable, explain the rationale behind your change.

@coveralls
Copy link

coveralls commented Nov 13, 2020

Pull Request Test Coverage Report for Build 1043

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 95.907%

Totals Coverage Status
Change from base Build 1024: 0.004%
Covered Lines: 6154
Relevant Lines: 6337

💛 - Coveralls

DuyguA
DuyguA previously approved these changes Nov 24, 2020
@mromdhane mromdhane self-requested a review January 22, 2021 15:36
@cyriaka90
Copy link
Contributor Author

Any updates here? :)

@mromdhane mromdhane self-assigned this Apr 30, 2021
@mromdhane
Copy link
Contributor

mromdhane commented Apr 30, 2021

@cyriaka90 you use the library only with script right?
With the command line, the library is not working with Turkish language
num2words 0 -l tr gives 'Num2Word_TR' object has no attribute 'str_to_number'

@cyriaka90
Copy link
Contributor Author

Thanks for your feedback! Somehow num2words isn't working with the command line for me :/ so yes, I use it only via script.

Would adding

    def str_to_number(self, value):
        return Decimal(value)

to lang_TR.py solve the problem?

@mromdhane
Copy link
Contributor

@cyriaka90 Yes you can do it, Thank you

@cyriaka90
Copy link
Contributor Author

@mromdhane I updated the PR - does Turkish now work with the command line?

@mromdhane
Copy link
Contributor

@cyriaka90 yes ! I merge it
Thank you

@mromdhane mromdhane merged commit 8061cf3 into savoirfairelinux:master May 7, 2021
@cyriaka90
Copy link
Contributor Author

Thank you!! :)

@cyriaka90 cyriaka90 deleted the turkish_zero branch May 7, 2021 15:40
KommuSoft pushed a commit to hapytex/num2words that referenced this pull request Aug 18, 2022
* [tr] return Turkish 0 ordinal and cardinal

* add str_to_number to Turkish

* try rather use Num2Word_Base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turkish: 0 doesn't return anything
4 participants