added swedish language including test cases #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 974
💛 - Coveralls |
|
@peternordstrom could you please, add tests for the missing lines on https://coveralls.io/builds/35506839/source?filename=num2words%2Flang_SV.py#L98? We can't merge the PR if the coverage decreases. |
…r options not implemented.
|
@mromdhane, I have updated the code so that it passes all tests now. See if it looks ok to you. |
erozqba
reviewed
Jan 28, 2021
There was a problem hiding this comment.
@peternordstrom thanks for updating the tests. I forgot to suggest you update the README.md also to include Swedish on the list of languages, could you do it, please.
Any intention to implement year, currency and ordinal ?
|
I updated the Readme now.
I might implement year, currency and numordinal later but for now, this is
what I have time for. And I believe these are the most important
implementations.
Cheers
Peter
…On Thu, 28 Jan 2021, 05:19 Ernesto Rodriguez Ortiz, < ***@***.***> wrote:
***@***.**** commented on this pull request.
@peternordstrom <https://github.com/peternordstrom> thanks for updating
the tests. I forgot to suggest you update the README.md also to include
Swedish on the list of languages, could you do it, please.
Any intention to implement year, currency and ordinal ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#352 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDVLZCX46TJX2K3FXYMAD3S4DQTPANCNFSM4UQO2GUA>
.
|
mromdhane
approved these changes
Jan 28, 2021
|
@peternordstrom Thank you for adding the Swedish language and hope to continue the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # by...
Changes proposed in this pull request:
Status
How to verify this change
Check if words look reasonable? Compare to Norweigan.
Additional notes
Swedish rules are very similar to norweigan so it was pretty easy to add this language