-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic farsi support #354
Conversation
Pull Request Test Coverage Report for Build 2799369812
💛 - Coveralls |
@HKalbasi could you please, add some tests for the missing lines on the coverage https://coveralls.io/builds/35770814/source?filename=num2words%2Flang_FA.py |
@erozqba Done. |
@HKalbasi has you can see the tests are failing, could you fix them, pelase? |
Just one of them remains, But I don't know what is the problem and how to solve it. Maybe it is due to python2 problem with unicode? |
@HKalbasi The test failed: Can you check it please `FAIL: test_ordinal (tests.test_fa.Num2WordsFATest) Traceback (most recent call last): File "/home/travis/build/savoirfairelinux/num2words/tests/test_fa.py", line 43, in test_ordinal
AssertionError: '\xd8\xa8\xdb\x8c\xd8\xb3\xd8\xaa \xd9\x88 \xd8\xb3\xd9\x87\xd9\x85' != '\xd8\xa8\xdb\x8c\xd8\xb3\xd8\xaa \xd9\x88 \xd8\xb3\xd9\x88\xd9\x85` |
I had seen it. But I don't know what those cryptic characters mean. When I print them those are this:
It seems there is a unicode issue with python2 which I know nothing about them. You did not have the same problem before? For example, for Arabic? Any idea? By the way, python2 is dead more than one year. Do you still need to check it in the CI? |
We should probably remove it any time soon, but sadly python 2.7 still continue to be used a lot. |
Do I have to do anything else or just wait?
Yes, but they do not need the latest version of this library. |
Changes proposed in this pull request:
Status
How to verify this change
You can check tests if you know Farsi.
Additional notes
This motivates me.