Icelandic #380
Merged
Icelandic #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 31, 2021 22:03
|
@biggboss83 can you update your branch with master, please. and let me know when your code is ready. |
|
@biggboss83 Will you continue to work on this? if so can you update the PR status and merge the changes added in master, |
|
I'm planning on completing this but since this is my first open source PR I could use some extra guidance. Can I pull the latest master branch, add my code and submit again? |
mrodriguezg1991
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Status
How to verify this change
Test num2words using
to_cardinalandlang_is.Additional notes
Not sure whether to put as Ready or WIP since cardinals are ready but not others.
Will complete rest soon.