Improve Ukrainian support and minor fixes in CZ, KZ, LT, LV, PL, RU, SR languages #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V, PL, RU, SR and UK languages
Pull Request Test Coverage Report for Build 1071
💛 - Coveralls |
|
@mromdhane |
|
Hello, @mromdhane |
|
Hello, @rostyslav80 can you just give us a little example of bug fixing, please? |
|
@mromdhane Before fixing: After fixing: |
|
@rostyslav80 Thank you! |
mromdhane
approved these changes
Jun 30, 2021
This was referenced Jul 7, 2021
Closed
KommuSoft
pushed a commit
to hapytex/num2words
that referenced
this pull request
Aug 18, 2022
…SR languages (savoirfairelinux#400) * Fix English char 'i' in Ukrainian words * Fix the feminine currency processing for UAH in lang_UK.py * Fix test_ua.py * Fix the feminine currency processing for UAH in lang_RU.py * Add tests for UAH in test_ru.py * Add world currencies to lang_UK.py; Add test cases to test_uk.py for world currencies * Fix incorrect handling of zeros after decimal point for CZ, KZ, LT, LV, PL, RU, SR and UK languages * Add ukrainian ordinal numbers * Fix too long lines of code * Add test for negative cardinal number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # by rostyslav80
Changes proposed in this pull request:
Status
How to verify this change
Unit tests cover all of the possible cases.
Additional notes
This PR contains the bug fix, proposed in these abandoned PRs: