You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*All tests pass
*Google translate isn't 100% accurate for Tajik. Tajik is a Persian language but the only one that uses Cyrillic. There isn't a similar language file.
*Trust me.
The code I added for Tajik support is at 100% coverage. None of the checks completed. Are those supposed to run automatically or is a review required first? This is my first pull request. I'm pretty excited to both be contributing to my first open source project and to be adding Tajik language support. I've attempted to make sure I'm not missing anything but if I am just let me know what I need to do. Thanks!
@mromdhane Is there a typical timeline of when the pull request should be reviewed and merged? Again, this is my first contribution to an open source project and didn't know how long I should be waiting for this. Thanks.
I've fixed the flake8 errors and run tox locally and everything passes. I've been waiting over a year to see my contributions merged and would love if you could see that happen.
I've fixed the flake8 errors and run tox locally and everything passes. I've been waiting over a year to see my contributions merged and would love if you could see that happen.
Sorry for the inconvenience, everything should be ok, this changes will be added in a new release soon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # by Drew Echerd
Changes proposed in this pull request:
Status
How to verify this change
*All tests pass
*Google translate isn't 100% accurate for Tajik. Tajik is a Persian language but the only one that uses Cyrillic. There isn't a similar language file.
*Trust me.
Additional notes