Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] to ordinal number for Turkish #468

Merged
merged 11 commits into from
Aug 18, 2022

Conversation

ieski
Copy link
Contributor

@ieski ieski commented Aug 17, 2022

Added Turkish Ordinal Number # by...

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

@ieski
Copy link
Contributor Author

ieski commented Aug 17, 2022

@mrodriguezg1991

thank you for your feedback.

sent again pull request

@coveralls
Copy link

coveralls commented Aug 17, 2022

Pull Request Test Coverage Report for Build 2883658952

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 96.551%

Totals Coverage Status
Change from base Build 2876554493: 0.001%
Covered Lines: 7220
Relevant Lines: 7399

💛 - Coveralls

@mrodriguezg1991
Copy link
Contributor

@ieski Hello and thanks for the contribution
The test coverage decreased , can you write some test to validate your change, and to increase the test coverage ?
Thanks

@ieski
Copy link
Contributor Author

ieski commented Aug 17, 2022

@ieski Hello and thanks for the contribution The test coverage decreased , can you write some test to validate your change, and to increase the test coverage ? Thanks

ok. i sent it

thanks

@mrodriguezg1991
Copy link
Contributor

@ieski hello
Can you fix the flake 8 issues on python3.10 ?

  flake8 run-test: commands[0] | flake8
  ./tests/test_tr.py:187:44: E231 missing whitespace after ','
  ./tests/test_tr.py:188:44: E231 missing whitespace after ','
  ./tests/test_tr.py:189:44: E231 missing whitespace after ','

Thanks

@mrodriguezg1991 mrodriguezg1991 merged commit 48dd5bd into savoirfairelinux:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants