Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#454: [tr] fix negative number problem #477

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

emregeldegul
Copy link

@emregeldegul emregeldegul commented Aug 19, 2022

#454 Negative Number return wrong text Fixes @emregeldegul

Changes proposed in this pull request:

  • -50 (cardinal) -> eksielli
  • -3 (currency) -> eksiellilira

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Add new cases in the turkish test for negative numbers

Additional notes

I opened a PR before but closed it because there were too many conflicts.

@mrodriguezg1991
Copy link
Contributor

@emregeldegul can you fix this for python3.10?

   flake8 run-test: commands[0] | flake8
  ./tests/test_tr.py:192:80: E501 line too long (82 > 79 characters)

@emregeldegul
Copy link
Author

@emregeldegul can you fix this for python3.10?

   flake8 run-test: commands[0] | flake8
  ./tests/test_tr.py:192:80: E501 line too long (82 > 79 characters)

i fixed it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.555% when pulling a7d095c on emregeldegul:#454 into a218b33 on savoirfairelinux:master.

@mrodriguezg1991 mrodriguezg1991 merged commit 931d71b into savoirfairelinux:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants