Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pt_PT #99

Closed
wants to merge 1 commit into from
Closed

Added pt_PT #99

wants to merge 1 commit into from

Conversation

hmrodrigues
Copy link

Added Portuguese (from Portugal)

@erozqba
Copy link
Collaborator

erozqba commented Oct 24, 2017

Hello, @hmrodrigues thanks for taking the time to make this PR.

I will suggest naming it simply 'pt', no need for 'pt_PT'. You could probably make a refactoring of the existing pt_BR to make the class pt_BR inherited from pt.

You will need to add some tests and to update the readme file too.

Thanks a lot!

@ventilooo
Copy link
Contributor

@hmrodrigues any update ?

@erozqba
Copy link
Collaborator

erozqba commented Oct 25, 2018

This was already implemented on #198

@erozqba erozqba closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants