Fixed #720: Restricted button to remove scheduled status to admin users

[aaboffill]

Fixes # by aaboffill

Changes proposed in this pull request:

• Added restriction to show the button to remove Scheduled Status Change to the admin users only.

Status

• READY
• HOLD
• WIP (Work-In-Progress)

How to verify this change

• Login into the system with a not admin user.
• Go to a client's view.
• Schedule a status change by using the status button, at the top-right.
• Go to the list and the button to remove Schedule Status Change won't be displayed.

[coveralls]

Coverage remained the same at 94.846% when pulling fb08749 on aaboffill:dev_720 into 2075ffb on savoirfairelinux:dev.

[coveralls]

Coverage increased (+0.09%) to 94.934% when pulling 61ed13c on aaboffill:dev_720 into 2075ffb on savoirfairelinux:dev.

[lingxiaoyang]

@aaboffill I'm sorry, I forgot to tell you that we have been using "rules" for the permission control: see this change in PR #592.

Code references:
https://github.com/savoirfairelinux/sous-chef/blob/dev/src/sous_chef/rules.py
In template: https://github.com/savoirfairelinux/sous-chef/blob/dev/src/member/templates/client/list.html#L15
In view function: https://github.com/savoirfairelinux/sous-chef/blob/dev/src/member/views.py#L51

Apart from this, all seems good to me. Can you change ".is_staff" to "sous_chef.edit"?

[aaboffill]

@lingxiaoyang I added your suggestions using the defined rules.

[coveralls]

Coverage increased (+0.01%) to 94.86% when pulling 3aed260 on aaboffill:dev_720 into 2075ffb on savoirfairelinux:dev.

[aaboffill]

@lingxiaoyang This is an example of the ugly python code when we have 79 characters as the line limit. It's my opinion!

[lingxiaoyang]

I think it may be unavoidable in some cases, even with a higher limit. But 79 is not enough for a Django application, for sure.

[lingxiaoyang]

Verified:

vs