Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #704: Change Member.address from ForeignKey to OneToOneField. #722

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Fixed #704: Change Member.address from ForeignKey to OneToOneField. #722

merged 1 commit into from
Apr 9, 2017

Conversation

lingxiaoyang
Copy link
Contributor

Fixes #704 by lingxiaoyang

Changes proposed in this pull request:

  • Model change: ForeignKey -> OneToOneField
  • Model migration: deals with shared address instances.
  • Unit test on model migration.

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Before applying the migration, in Django backend admin, make two or more clients linking to the same Address instance.

Do the migration. Then check the address instances of these clients, which should then be separated.

Deployment notes and migration

  • Migration is needed for this change

New translatable strings

none

Additional notes

none

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.968% when pulling c19d2a6 on lingxiaoyang:fix_704 into 2075ffb on savoirfairelinux:dev.

@erozqba
Copy link
Contributor

erozqba commented Apr 9, 2017

👍

@erozqba erozqba merged commit 04044df into savoirfairelinux:dev Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants