Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the callback one last time. #51

Merged
merged 3 commits into from Mar 3, 2015
Merged

Call the callback one last time. #51

merged 3 commits into from Mar 3, 2015

Conversation

klondi
Copy link
Contributor

@klondi klondi commented Mar 3, 2015

The status is updated way after the event handler is called, also any output remaining on the queue will be processed without calling the callback. This prevents such
conditions which amongst other things allows to have callbacks like this:

def mycallback(nm):
if (nm.has_terminated()):
print ("Done!")

The status is updated way after the event handler is called, also any output remaining on the queue will be processed without calling the callback. This prevents such
conditions which amongst other things allows to have callbacks like this:

def mycallback(nm):
    if (nm.has_terminated()):
        print ("Done!")
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 67.87% when pulling c79c8b0 on klondi:master into 4b0dd0a on savon-noir:master.

@savon-noir
Copy link
Owner

could you please rebase and reissue your pull request? thanks!

@klondi
Copy link
Contributor Author

klondi commented Mar 3, 2015

Strange, this branch is based against the last one on github so there are no changes to rebase on. Did you push any changes you want me to rebase on?

$ git fetch gupstream
$ git rebase gupstream/master master
Previous HEAD position was 4b0dd0a... updated package for v0.6.2
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
Current branch master is up to date.
$ git push
Everything up-to-date

savon-noir added a commit that referenced this pull request Mar 3, 2015
Call the callback one last time.
@savon-noir savon-noir merged commit 5ef8564 into savon-noir:master Mar 3, 2015
@savon-noir
Copy link
Owner

ok, looks good. Thanks for your contribution, pull reqs are always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants