Open stdout and stderr as text streams #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nmap stdout and sterr is being used as str. This opens the streams as text, so read()/readline() returns a str instead of a byte, avoiding the need to manually decode from str to byte on each read(). This fixes savon-noir#63 which is an endless loop caused by enumerate() waiting for a '' as sentinel but receiving a b''. Also, NmapProcess.__process_event() expects stderr as str, using a byte breaks it, which in turn breaks NmapProcess.run_background() and NmapProcess.sudo_run_background()
savon-noir
added a commit
that referenced
this pull request
Feb 28, 2016
Open stdout and stderr as text streams
|
Thanks a lot for checking this out. Lots of ppl were asking for a fix for this issue but nobody wanted to issue a fix :) Thanks again. |
|
No problem. Such a neat library didn't deserve that issue :) I'll be waiting for the next repackage on pypi |
|
pypi updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nmap stdout and sterr is being used as str. This opens the streams
as text, so read()/readline() returns a str instead of a byte, avoiding
the need to manually decode from str to byte on each read().
This fixes #63 which is an endless loop
caused by enumerate() waiting for a '' as sentinel but receiving a b''.
Also, NmapProcess.__process_event() expects stderr as str, using a byte
breaks it, which in turn breaks NmapProcess.run_background() and
NmapProcess.sudo_run_background(). #58
doesn't solve this issue.