Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP GET/POST (and I assume others) return no body data #1417

Closed
alexhorner opened this issue Nov 28, 2020 · 2 comments
Closed

HTTP GET/POST (and I assume others) return no body data #1417

alexhorner opened this issue Nov 28, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@alexhorner
Copy link

Describe the bug
HTTP requests do not return any data in the (status, headers, data) return.

To Reproduce

let (status, headers, data) = http.get("https://www.google.com/");

log("Status: #{status}");
log("Headers: #{headers}");
log("Data: #{data}");

output.dummy(blank());

Expected behavior
The data log should contain the HTML output of the google page (When I call my server, I should get the expected data back, in my case JSON)

Version details

  • OS: Ubuntu 18.04.5 LTS + Docker and Windows 10 Professional + Docker - Both reproduce the bug
  • Version: 1.4.3

Install method
OPAM

Log Output

2020/11/28 20:05:22 >>> LOG START
2020/11/28 20:05:21 [main:3] Liquidsoap 1.4.3
2020/11/28 20:05:21 [main:3] Using: bytes=[distributed with OCaml 4.02 or above] pcre=7.4.6 sedlex=2.2 menhirLib=20201122 dtools=0.4.2 duppy=0.8.0 cry=0.6.5 mm=0.5.0 ogg=0.5.2 vorbis=0.7.1 mad=0.4.5 flac=0.1.7 flac.ogg=0.1.7 dynlink=[distributed with Ocaml] lame=0.3.4 bjack=0.1.5 ao=0.2.1 taglib=0.3.6 camomile=1.0.2
2020/11/28 20:05:21 [dynamic.loader:3] Could not find dynamic module for fdkaac encoder.
2020/11/28 20:05:22 [lang:3] Status: ("HTTP/1.0", 200, "OK")
2020/11/28 20:05:22 [lang:3] Headers: [("date", "Sat, 28 Nov 2020 20:05:22 GMT"), ("expires", "-1"), ("cache-control", "private, max-age=0"), ("content-type", "text/html; charset=ISO-8859-1"), ("p3p", "CP=\"This is not a P3P policy! See g.co/p3phelp for more info.\""), ("server", "gws"), ("x-xss-protection", "0"), ("x-frame-options", "SAMEORIGIN"), ("set-cookie", "1P_JAR=2020-11-28-20; expires=Mon, 28-Dec-2020 20:05:22 GMT; path=/; domain=.google.com; Secure"), ("set-cookie", "NID=204=WiN8UEQmBX3NvrdFhThDFgySgEjXwV_K4JYRxoZFGmmnjspXV6nEj-Ucx52W_Z2t6Fr1Nr1Bxbg4a94ZN_iAvYUf1p8v5j3QJfctamT36P7TeMUW-4-u-zvyeun8782uA7CnnPbPaQboYjhuXGtRRpJIsiwjeGwXaDIDf_0-rb0; expires=Sun, 30-May-2021 20:05:22 GMT; path=/; domain=.google.com; HttpOnly"), ("accept-ranges", "none"), ("vary", "Accept-Encoding")]
2020/11/28 20:05:22 [lang:3] Data:
2020/11/28 20:05:22 [frame:3] Using 44100Hz audio, 25Hz video, 44100Hz master.
2020/11/28 20:05:22 [frame:3] Frame size must be a multiple of 1764 ticks = 1764 audio samples = 1 video samples.
2020/11/28 20:05:22 [frame:3] Targetting 'frame.duration': 0.04s = 1764 audio samples = 1764 ticks.
2020/11/28 20:05:22 [frame:3] Frames last 0.04s = 1764 audio samples = 1 video samples = 1764 ticks.
2020/11/28 20:05:22 [sandbox:3] Running inside a docker container, disabling sandboxing..
2020/11/28 20:05:22 [video.converter:3] Couldn't find preferred video converter: gavl.
2020/11/28 20:05:22 [audio.converter:3] Using samplerate converter: native.
2020/11/28 20:05:22 [clock.wallclock_main:3] Streaming loop starts, synchronized with wallclock.
@toots
Copy link
Member

toots commented Nov 29, 2020

Looks like I can reproduce and it, if so, it's a bad bug. I'll prioritize looking into it. Thanks for reporting.

@toots toots self-assigned this Nov 29, 2020
@toots toots closed this as completed in aacc009 Nov 30, 2020
@toots
Copy link
Member

toots commented Nov 30, 2020

Issues is fixed. Watch for a 1.4.4 bugfix, should appear as pre-release here once the CI completes: https://github.com/savonet/liquidsoap/releases

@toots toots added this to the 1.4.4 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants