Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive.harbor handles does not handle [&<>"'] characters well #3418

Closed
ghostnumber7 opened this issue Sep 21, 2023 · 1 comment
Closed

Comments

@ghostnumber7
Copy link
Contributor

Describe the bug
When using interactive.harbor() there are a few issues with the /interactive form:

  • If a field description contains a < character it breaks the interfase
  • If an interactive.string() value contains some combinations of '<> if breaks the interfase
  • If an interactive.string() value contains some combinations of +&= the value is not saved correctly

To Reproduce

interactive.harbor()
metadataTransformRegex = interactive.string(
  description = "Metadata transform regex (Example: StreamTitle='(?<artist>[^~]*?)\\s*~(?<title>[^~]*?)\\s*~ )",
  "metadataTransformRegex", "'>oops"
)

Go to localhost:8000/interactive and see it broken

Expected behavior
HTML entities should be escaped and form should be url encoded when submitting

Version details

  • Ubuntu
  • 2.2.0

Install method
opam

@toots
Copy link
Member

toots commented Sep 24, 2023

Fixed with 81f4bca and 113ead7

@toots toots closed this as completed Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants