-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falls stream, with the process still running #596
Comments
Thanks! One more question: does the process still react when you do |
Could you also send me the file |
Just a suggestion but maybe it’s a flaw in the crossfading where the streams stops in between song changes instead of crossfading if you know what I mean. So it’s disconnected from icecast because the source ended but liquidsoap is still generating a stream. You could try something similar such as output.sdl() for audio though and observed that. If @toots could confirm that function for me |
@toots |
Hi! So, in the process of reviewing the
Thks! |
Ok. |
@toots
|
Well at least now we won't have to wait 8h each time ;-) Can you send a full log of the transition? Thks! |
Maybe you need to add more logs in the smartcross statement? |
|
Looks like you're not running the latest code. This transition should not have been crossfaded with the recent changes because there isn't the same amount of buffer in
|
Shoot my bad I forgot one step in the install instructions. Let me try again:
|
Exactly. I did not notice a new branch. |
@toots
Why does he ask for gavl if I only have audio via an external encoder? And the decoder is used only by the faad. 😕 |
Wow. I have no idea what could cause that. What version of OCaml are you using to build? I'd suggest switch to the latest, |
4.06.0. There were some problems under 4.07.0, but I'll try again. |
Ok. I'm starting to believe that your issue has nothing to do with what we were looking for. If you get another hard freeze like that the next step would prolly be to look at it with |
@toots #596 (comment) |
Any luck with the latest changes? |
While everything works. (Jingles + crossfade, without ladspa). |
If all goes well, I'll try to connect ladspa. Also check with the fdkaac encoder. |
Crossing fingers!! |
By the way, I did not change the transition in crossfade. It works through |
Ok. Change it back too then when you feel like it. It wasn't used, tho, the |
I'm noticing a similar issue on 1.3.3, and it's driving me crazy as I'm working on other issues, getting clouded by this, and I didn't even suspect smart_crossfade. I'll switch to the given branch to check, but the process stalls, ^C isn't treated, I have to check what happens to the server socket, but it seemed dead to me. |
OK, happened again, so icecast output goes down, liq stops outputting on stdout, doesn't respond to ^C. server socket is still connected (no timeout), and tells:
But then I hit ^D and couldn't talk to liq through the socket anymore.
This happened at 01:07:13, stream started at 20:58:25. Liq process was still using RAM and CPU, strace yields this:
I couldn't get a coredump as the env wasn't set for it, but I restarted it using gdb, so we'll see... I will try the branch if that is relevant. |
Try this branch smartcross-cleanup. With the latest changes, the stream does not seem to fall any more. P.s. Build with ocamlc: 4.07.0. (mm, dtools, duppy from master branches) |
I will try the branch, just dumping here the gdb output after I killed the process on 1.3.3
|
I didn't notice the spec about ocamlc version 4.07.0, though I can get it from opam, I'd rather stick to the distribution version unless I have to, as opam isn't nicely wired yet in our upgrade process. I guess we'll have a test case of the branch+ocaml 4.05 ;) |
Ha, I missed the opam warning, it won't install the pinned version, and I'm back on dependency hell... |
@gilou
|
See #603 hehe, but I figured it out, however I'm fully relying on dev versions for mm & dtools now... But I trust all will be fixed once this is closed... |
I think this will be fixed for release 1.3.4. |
Which is imminent! |
Gonna merge and close, please report if y'all see more issues. |
@toots #596 (comment) |
It froze again using master for mm, duppy, faad and liq... maybe something is inconsistent, here's the bt: bt.txt |
@gilou, do you have the logs? I see |
On this note, if it froze while shutting down, make sure you have the latest |
I sent ^C to no avail, then ^Z to get control of the shell. I'm running a trimmed version of the script, something still makes it barf, but it could be many things... And I'm running from git master of each of the components. |
OK, once back on the simple version with only crossfade, it holds, I'm still running tests... but the culprit seems to be once again around pipe() or outside processes, wether on sources or because of dynamic replaygain metadata extraction. I'll stop spamming here and open another issue once I can pinpoint it more precisely. Thanks a lot Romain for following up on this. |
The problem is that after a certain time (usually a day or two), the stream falls and is not available for listening at the icecast, but the liquidsoap process itself works.
Logs also stop writing.
The problem is noticed when the track / jingle changes.
It was found that the stream falls when the crossfade (joshcross) is included along with the jingles. When you disable the crossfade, everything works.
It was tested on the release version of opam with the compiler ocaml 4.06.0, with faad, mm, dtools and liquidsoap from the master branch.
config: config.liq.txt
utils: utils.liq.txt
logs: liquidsoap.log.txt
In some tracks, sometimes -NaNdb is analyzed.
Some work has been done in another topic: #572 (comment)
The text was updated successfully, but these errors were encountered: