Set default encoding to UTF8 in icecast/shoutcast operators. #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
unicode-default
branch
from
8b14e1a
to
db8a24b
Compare
toots
force-pushed
the
unicode-default
branch
from
db8a24b
to
8d8555e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #2701. Looking around, it seems that nowadays, most software expect UTF-8 encodings out of the box, including in legacy systems where non-UTF-8 used to be the default such as shoutcast.
In order to follow the most expected best happy path, this PR switches these legacy systems to UTF-8. The option to encode to different encodings should be available for anyone still using a legacy system.