Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Re.Pcre instead of Pcre #9

Merged
merged 2 commits into from Jan 2, 2024
Merged

Conversation

glondu
Copy link
Contributor

@glondu glondu commented Dec 2, 2021

Rationale: Pcre depends on an obsolete library:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000004

@toots
Copy link
Member

toots commented Dec 2, 2021

Hi,

I looked at converting liquidsoap to it recently and, despite a compatibility layer, the runtime behavior appeared to break pretty hard.

I'll have another pass at it shortly.

@glondu
Copy link
Contributor Author

glondu commented Jul 29, 2023

Any news on this?

Could you be more specific on how the runtime behavior breaks "pretty hard" with re? Are there tests I can easily run to check non-regression?

In Debian, the dependency on pcre has become release critical.

@glondu
Copy link
Contributor Author

glondu commented Jul 29, 2023

Reported as Debian bug in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042499

@glondu
Copy link
Contributor Author

glondu commented Sep 14, 2023

What is the status of this pull request?

FYI, ocaml-duppy has just been automatically removed from testing.

@toots
Copy link
Member

toots commented Sep 18, 2023

The switch is still planned just not a top priority at the moment. Really appreciate the work put in making re support our last feature. We will do the switch before the next major release.

@toots toots added this pull request to the merge queue Jan 2, 2024
Merged via the queue into savonet:main with commit e8d033d Jan 2, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants