Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-gstreamer should run a loop in the thread where it is created. #12

Open
crocket opened this issue Jul 26, 2019 · 0 comments
Open

Comments

@crocket
Copy link

crocket commented Jul 26, 2019

At the end of liquidsoap/src/tools/gstreamer_utils.ml, Gstreamer.Loop.create () creates a loop in the global-default glib main context which runs the loop in the main thread instead of gstreamer_main_loop thread.

Tutils.create main () "gstreamer_main_loop" seems to intend to run the gstreamer loop in gstreamer_main_loop thread.

To run a gstreamer loop in gstreamer_main_loop thread,

I don't know whether creating a new thread-default glib main context for gstreamer_main_loop thread breaks ocaml-gstreamer or liquidsoap.

ocaml-gstreamer needs to stop depending on the global-default glib main context if it does.

@crocket crocket changed the title ocaml-gstreamer should create a loop in a new thread. ocaml-gstreamer should run a loop in a new thread. Jul 26, 2019
@crocket crocket changed the title ocaml-gstreamer should run a loop in a new thread. ocaml-gstreamer should run a loop in the thread where it is created. Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant