Prevent ocaml_gstreamer_loop_quit from freezing during shutdown #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it calls g_main_loop_quit(loop) directly. Thus, g_main_loop_quit can be called before g_main_loop_run is called if liquidsoap tries to exit immediately after it is started. Thread execution order is undetermined. I fixed the issue by making it call g_main_loop_quit in the loop. If it is called in the loop, there is no freezing.
This was referenced Jul 26, 2019
|
Hi, I'm just a stupid end-user. I see this issue passed all checks and was done on July 25th, but the latest commit to master was done on July 1st. I don't get it, but I'm no dev. Is this change not into the production code yet? I just want this code to be 'fixed', so I can ask the liquidsoap rpm repo experts to do a recompile. I want to upgrade liquidsoap on a few servers so it will stop hanging, and I don't want to compile and deploy code myself (well, I deploy rpm's using spacewalk). Help? |
|
@AxisNL Ask your linux distribution's maintainers to apply this pull request as a patch to the latest release. |
|
Closing due to inactivity and because I don't use this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it calls
g_main_loop_quit(loop)directly.Thus,
g_main_loop_quitcan be called beforeg_main_loop_runis called if liquidsoap tries to exit immediately after it is started because thread execution order is undetermined.If
g_main_loop_quitcan be called beforeg_main_loop_runis called, ocaml-gstreamer can freeze.I fixed the issue by making it call
g_main_loop_quitin the loop.If it is called in the loop, there is no freezing during shutdown.