Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading of cert/private key from memory #54

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

Lupus
Copy link
Contributor

@Lupus Lupus commented Sep 22, 2019

This PR adds wrapper function to configure certificate/private key using in-memory buffers

@toots toots requested a review from smimram September 22, 2019 16:17
@smimram
Copy link
Member

smimram commented Dec 9, 2019

I am fine with the certificate_from_string function, but why did you have to change the get_method function? Are you sure it's innocuous? I'd rather have two separated PRs, if you want some other changes.

@Lupus
Copy link
Contributor Author

Lupus commented Dec 9, 2019

Oops, looks like I pushed more commits to my fork not taking into account that they will get attached to opened PR... Sorry, I'll remove those and will post deprecated api fix as separate PR.

@Lupus
Copy link
Contributor Author

Lupus commented Dec 9, 2019

Okay, I've reverted the branch to only include original commit which adds certificate_from_string.

@smimram
Copy link
Member

smimram commented Dec 9, 2019

All good for me now, thanks!

@smimram smimram merged commit 283d052 into savonet:master Dec 9, 2019
@Lupus
Copy link
Contributor Author

Lupus commented Dec 9, 2019

Cool, thanks for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants