Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ocaml-ssl in nnpchecker mode #98

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

kit-ty-kate
Copy link
Contributor

@kit-ty-kate kit-ty-kate commented Oct 27, 2022

Detected in ocaml/opam-repository#22363 (comment)
and debugged using rr as described in https://discuss.ocaml.org/t/ann-a-dynamic-checker-for-detecting-naked-pointers/5805 to find that the pointer came from ocaml-ssl

@anmonteiro
Copy link
Collaborator

To help me understand, does the following make sense?

  • the code is already compatible with "no naked pointers" (default in 5.0)
  • there's a version of the compiler that checks naked pointers, which defines this different NAKED_POINTERS_CHECKER

@kit-ty-kate
Copy link
Contributor Author

Yes, nnpchecker has been an option since OCaml 4.12. Technically what it does is:

  • allow naked pointer
  • but add an extra check to detect uses of naked pointer, print them to make them debuggable
  • and make the program fail if it encountered one (since OCaml 4.13, useful for CI)

@anmonteiro anmonteiro merged commit e42d4cd into savonet:master Oct 27, 2022
@anmonteiro
Copy link
Collaborator

Awesome -- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants