Skip to content

Commit

Permalink
Merge pull request #116 from savonrb/fix_logger_nomethoderror
Browse files Browse the repository at this point in the history
Fix NoMethodError when not using NTLM
  • Loading branch information
rogerleite committed Jun 11, 2014
2 parents 15eb7a7 + 165e2e4 commit 0277b6a
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 42 deletions.
43 changes: 1 addition & 42 deletions lib/httpi.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require "logger"

require "httpi/version"
require "httpi/logger"
require "httpi/request"

require "httpi/adapter/httpclient"
Expand Down Expand Up @@ -145,42 +144,6 @@ def adapter=(adapter)
Adapter.use = adapter
end

# Sets whether to log HTTP requests.
attr_writer :log

# Returns whether to log HTTP requests. Defaults to +true+.
def log?
@log != false
end

# Sets the logger to use.
attr_writer :logger

# Returns the logger. Defaults to an instance of +Logger+ writing to STDOUT.
def logger
@logger ||= ::Logger.new($stdout)
end

# Sets the log level.
attr_writer :log_level

# Returns the log level. Defaults to :debug.
def log_level
@log_level ||= DEFAULT_LOG_LEVEL
end

# Logs a given +message+.
def log(message)
logger.send(log_level, message) if log?
end

# Reset the default config.
def reset_config!
@log = nil
@logger = nil
@log_level = nil
end

private

def request_and_adapter_from(args)
Expand All @@ -192,9 +155,5 @@ def load_adapter(adapter, request)
Adapter.load(adapter).new(request)
end

def log_request(method, request, adapter)
log("HTTPI #{method.to_s.upcase} request to #{request.url.host} (#{adapter})")
end

end
end
50 changes: 50 additions & 0 deletions lib/httpi/logger.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
require "logger"

module HTTPI

class << self

# Sets whether to log HTTP requests.
attr_writer :log

# Returns whether to log HTTP requests. Defaults to +true+.
def log?
@log != false
end

# Sets the logger to use.
attr_writer :logger

# Returns the logger. Defaults to an instance of +Logger+ writing to STDOUT.
def logger
@logger ||= ::Logger.new($stdout)
end

# Sets the log level.
attr_writer :log_level

# Returns the log level. Defaults to :debug.
def log_level
@log_level ||= DEFAULT_LOG_LEVEL
end

# Logs a given +message+.
def log(message)
logger.send(log_level, message) if log?
end

# Reset the default config.
def reset_config!
@log = nil
@logger = nil
@log_level = nil
end

protected

def log_request(method, request, adapter)
log("HTTPI #{method.to_s.upcase} request to #{request.url.host} (#{adapter})")
end

end
end

0 comments on commit 0277b6a

Please sign in to comment.