-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rubyntlm dependency from gemspec #107
Comments
Yes, sidekiq has an optional dependency on sinatra because the Web UI is optional. I just have to document that people need to add it to their Gemfile to use the Web UI in their application. For development purposes, you use a Gemfile with all your dependencies listed, optional or required. The gemspec only lists required dependencies. |
If you have a specific version requirement, the best you can do is something like this in your code: begin
require 'rubyntlm'
raise ArgumentError, "Invalid version of rubyntlm, please upgrade to 1.1.15" if defined?(RubyNTLM) && RubyNTLM::VERSION < '1.1.15'
rescue LoadError
end |
Decided to bump the minor version number because this is technically a breaking change in the API. Fixes #107
Decided to bump the minor version number because this is technically a breaking change in the API. Fixes #107
Listing optional dependencies like rubyntlm in your gemspec just adds more gems to the Gemfile.lock for applications that use Savon, even though there is little chance they will ever use NTLM suppport.
The text was updated successfully, but these errors were encountered: