Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rubyntlm dependency from gemspec #107

Closed
mperham opened this issue Jan 28, 2014 · 4 comments · Fixed by #108
Closed

Remove rubyntlm dependency from gemspec #107

mperham opened this issue Jan 28, 2014 · 4 comments · Fixed by #108

Comments

@mperham
Copy link

mperham commented Jan 28, 2014

Listing optional dependencies like rubyntlm in your gemspec just adds more gems to the Gemfile.lock for applications that use Savon, even though there is little chance they will ever use NTLM suppport.

@rogerleite
Copy link
Member

I agree with you @mperham .

Optional dependency is kind a pain on rubygems. Issue #101 proves it.
I'm trying to figure out how the best way to fix this.

Suggestions? Do you have any project with optional dependency?

Thanks

@mperham
Copy link
Author

mperham commented Jan 31, 2014

Yes, sidekiq has an optional dependency on sinatra because the Web UI is optional. I just have to document that people need to add it to their Gemfile to use the Web UI in their application.

For development purposes, you use a Gemfile with all your dependencies listed, optional or required. The gemspec only lists required dependencies.

@mperham
Copy link
Author

mperham commented Jan 31, 2014

If you have a specific version requirement, the best you can do is something like this in your code:

begin
  require 'rubyntlm'
  raise ArgumentError, "Invalid version of rubyntlm, please upgrade to 1.1.15" if defined?(RubyNTLM) && RubyNTLM::VERSION < '1.1.15'
rescue LoadError
end

tjarratt added a commit that referenced this issue Feb 1, 2014
Decided to bump the minor version number because this is technically a breaking
change in the API.

Fixes #107
tjarratt added a commit that referenced this issue Feb 1, 2014
Decided to bump the minor version number because this is technically a breaking
change in the API.

Fixes #107
@rogerleite
Copy link
Member

@mperham thanks for the tips! On version 2.2.0, rubyntlm will be optional.
Do you need this version now or i can wait more changes to release?

@tjarratt thanks a lot for the code! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants