fixing excon adapter to pass client_cert and key as strings instead of objects #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @drewnichols! Thanks for all information. I'm still in doubt. This feature Another thing, could you please squash your commits on one commit? This changes can be a one commit change. |
… and :private_key options as strings containing the pem formatted certificate and key when using client certificates as excon expects these arguments as strings and not objects
|
squash complete. it looks like :certificate and :private_key was introduced in 2013 v0.24.0 here: |
rogerleite
added a commit
that referenced
this pull request
Sep 30, 2015
Fix excon adapter to pass client_cert and key as strings instead of objects
|
Thanks @drewnichols! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is in reference to #161