Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to coveralls_reborn #216

Merged
merged 1 commit into from Nov 16, 2020
Merged

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Nov 15, 2020

The Travis build exhibit the issue reported here: lemurheavy/coveralls-ruby#161

It seems that the coveralls project is abandoned. There is a fork, coveralls_reborn, which is actively maintained https://github.com/lemurheavy/coveralls-ruby.

Disclaimer: I don't have any knowledge or opinion about the merits of coveralls_reborn apart from what I have red via the links above.

@olleolleolle
Copy link
Contributor

Thanks for offering this, @c960657 - seems like we have test failures, and there's a SSL Ciphers PR waiting. It can take some time before this is applied, I'd like to do it on top of a passing test suite.

@olleolleolle
Copy link
Contributor

Alright, we got there, and quicker than I thought! @c960657, would you be able to rebase this?

coveralls is abandoned
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the coveralls_reborn gem, and 👍 yeah, let's use that.

@olleolleolle olleolleolle merged commit 91d2d19 into savonrb:master Nov 16, 2020
@olleolleolle
Copy link
Contributor

Thanks, @c960657, for this second-today merged PR!

@rogerleite
Copy link
Member

🎯 👍 @c960657 @olleolleolle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants