Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec dev deps: Unpin rake, loosen puma #219

Closed
wants to merge 2 commits into from

Conversation

olleolleolle
Copy link
Contributor

In order to make it possible to install on Ruby 3.0.

And to avoid warnings about a CVE in Puma.

In order to make it possible to install on Ruby 3.0.

And to avoid warnings about a CVE in Puma.
@coveralls
Copy link

coveralls commented May 20, 2021

Coverage Status

Coverage increased (+0.2%) to 97.286% when pulling 04d2e78 on gemspec-loosen-rake-newer-puma into 497a304 on master.

@olleolleolle
Copy link
Contributor Author

olleolleolle commented May 20, 2021

excon adapter fails with SSL in unknown state:

https://stackoverflow.com/questions/33572956/ruby-ssl-connect-syscall-returned-5-errno-0-state-unknown-state-opensslssl

Could need some poking.

 Excon::Error::Socket:

   SSL_connect SYSCALL returned=5 errno=0 state=unknown state (OpenSSL::SSL::SSLError)
  1) HTTPI::Adapter::Excon https requests works with client cert and key provided as file path

     Failure/Error: respond_with @client.send(method)

     

     Excon::Error::Socket:

       SSL_connect SYSCALL returned=5 errno=0 state=unknown state (OpenSSL::SSL::SSLError)

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/ssl_socket.rb:135:in `connect_nonblock'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/ssl_socket.rb:135:in `initialize'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:461:in `new'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:461:in `socket'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:118:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/mock.rb:57:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/instrumentor.rb:34:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/idempotent.rb:19:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/base.rb:22:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/base.rb:22:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:273:in `request'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:359:in `get'

     # ./lib/httpi/adapter/excon.rb:25:in `request'

     # ./lib/httpi.rb:161:in `request'

     # ./lib/httpi.rb:127:in `get'

     # ./spec/integration/excon_spec.rb:148:in `block (3 levels) in <top (required)>'

     # ------------------

     # --- Caused by: ---

     # OpenSSL::SSL::SSLError:

     #   SSL_connect SYSCALL returned=5 errno=0 state=unknown state

     #   /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/ssl_socket.rb:135:in `connect_nonblock'

@olleolleolle olleolleolle force-pushed the gemspec-loosen-rake-newer-puma branch from ee57d21 to 04d2e78 Compare May 20, 2021 13:16
@ioquatix
Copy link
Contributor

ioquatix commented Oct 6, 2021

This can be closed?

@olleolleolle
Copy link
Contributor Author

Thanks, yes, now closable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants