We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The nokogiri parser checks if the stripped xml is empty before parser, but passes the unstripped XML to the parser.
This means the you have to strip it yourself before passing to the parser, which means the strip in the guard clause is unnecessary.
A better and more robust solution is for the Nori parse method to strip the xml before passing to Nokogiri.
I'll throw together a quick pull request.
The text was updated successfully, but these errors were encountered:
please do.
Sorry, something went wrong.
f1cb225
No branches or pull requests
The nokogiri parser checks if the stripped xml is empty before parser, but passes the unstripped XML to the parser.
This means the you have to strip it yourself before passing to the parser, which means the strip in the guard clause is unnecessary.
A better and more robust solution is for the Nori parse method to strip the xml before passing to Nokogiri.
I'll throw together a quick pull request.
The text was updated successfully, but these errors were encountered: