Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokogiri Parser should strip xml before parsing #16

Closed
aselder opened this issue Jun 8, 2012 · 1 comment
Closed

Nokogiri Parser should strip xml before parsing #16

aselder opened this issue Jun 8, 2012 · 1 comment

Comments

@aselder
Copy link

aselder commented Jun 8, 2012

The nokogiri parser checks if the stripped xml is empty before parser, but passes the unstripped XML to the parser.

This means the you have to strip it yourself before passing to the parser, which means the strip in the guard clause is unnecessary.

A better and more robust solution is for the Nori parse method to strip the xml before passing to Nokogiri.

I'll throw together a quick pull request.

@rubiii
Copy link
Contributor

rubiii commented Jun 30, 2012

please do.

@rubiii rubiii closed this as completed in f1cb225 Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants